Workflow repositories step doesn't honor selected status of repositories

[jabrah]

The selected status of an optional repository is resent when a user navigates back and forth within the submission workflow.

• Progress through submission workflow
• Deselect J10P repo
• Click Next to persist repositories on submission
• Click Back to reload the Repositories step
• J10P is selected again

This may be tricky to handle for draft submissions because it may not have the all of the information present within the workflow. Some values are held in non-persistent variables, such as repository._selected

[jabrah]

There are steps we can take to mitigate this bug, but I don't think it can be completely solved at this point.

For the scenario above, we could save the selection status in the in workflow.js which holds data through the workflow. This should address the repository selection navigating back and forth in the workflow.

However, there is the problem of loading a draft submission and going through the workflow. In this case, I don't think there is anything persisted with the submission that will tell us about the repository selection status with complete accuracy. We could attempt to infer the selection status, given enough information in the draft submission, such as saved repositories, policies, and the journal. This approach seems like it would be error-prone, though.

[markpatton]

This has already been fixed for non-draft submissions.