Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Builds] Remove elements unnecessary with the new version-bump workflow #2387

Conversation

HannesWell
Copy link
Member

With the new reusable workflow for automated version increments in pull-requests, introduced with #2352, it is not necessary anymore to bump versions in advance during release preparation or the enable bumping if the property 'compare-version-with-baselines.skip' is set to false. Everything now happens automatically and these elements can therefore be removed.

Removing these elements avoids partly duplicated configuration and generally reduced the amount of configuration.

@akurtakov
Copy link
Member

As thenew workflow is not yet setup on this repo, this one can not be pushed, right?

@HannesWell
Copy link
Member Author

As thenew workflow is not yet setup on this repo, this one can not be pushed, right?

This repository is not really the problem since the removed elements are (hardly) used here, but we should await until it's active in all other (active) SDK repositories. And while JDT should only be a matter of committer time, Equinox and SWT seem to need more adjustments and might take longer.

@HannesWell HannesWell force-pushed the remove-unnecessary-build-elements branch 2 times, most recently from 96dce5e to 19abb15 Compare November 23, 2024 11:06
With the new reusable workflow for automated version increments in
pull-requests it is not necessary anymore to bump versions in advance
during release preparation.
This now happens automatically as part of the PR verification and that
step can therefore be removed.
@akurtakov
Copy link
Member

Landing this part in.

@akurtakov akurtakov merged commit 56ba8ab into eclipse-platform:master Nov 23, 2024
2 of 4 checks passed
@HannesWell HannesWell deleted the remove-unnecessary-build-elements branch November 23, 2024 11:21
@HannesWell
Copy link
Member Author

Landing this part in.

To add some context, why this is important now:
The updateRelease workflow currently suffers the same problems like the workflow for automated version increment, which is why these two repos don't have it yet:

With this being submitted, Equinox and SWT still don't get the version-bumps on first change in the dev-cycle, but at least changing the parent-pom version should be possible now.

@HannesWell
Copy link
Member Author

For Equinox and SWT the following PRs could now be created, after renaming the existing 4.35 milestone creating a new one with the same original data and afterwards deleting the new one and restoring the name of the original one:

HannesWell added a commit to HannesWell/eclipse.platform.releng.aggregator that referenced this pull request Nov 23, 2024
That workflow now just updates pom.xml files.

Follow-up on
eclipse-platform#2387
HannesWell added a commit to HannesWell/eclipse.platform.releng.aggregator that referenced this pull request Nov 23, 2024
That workflow now just updates pom.xml files.

Follow-up on
eclipse-platform#2387
HannesWell added a commit that referenced this pull request Nov 24, 2024
That workflow now just updates pom.xml files.

Follow-up on
#2387
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants