Scaling of Color/Font Dialog not working properly after DPI change #1593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Nov 13, 2024
Test Results 483 files ±0 483 suites ±0 8m 31s ⏱️ - 1m 10s For more details on these failures, see this check. Results for commit b2c80a4. ± Comparison against base commit beb2391. ♻️ This comment has been updated with latest results. |
ShahzaibIbrahim
force-pushed
the
master-141
branch
from
db2b493 to
fa7e9f9
Compare
akoch-yatta
reviewed
Nov 14, 2024
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/ColorDialog.java
Outdated
Show resolved
Hide resolved
ShahzaibIbrahim
force-pushed
the
master-141
branch
2 times, most recently
from
0b96a81 to
b6b7f9b
Compare
Creating a separate UI thread to set the DPI Awareness context to use UNAWARE GDI scale before opening the either dialogs since windows has issues with dialog scaling in AWARE context
fedejeanne
force-pushed
the
master-141
branch
from
c377a80 to
b2c80a4
Compare
fedejeanne
approved these changes
Nov 28, 2024
|
Failing tests and checks are unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a separate UI thread to set the DPI Awareness context to use UNAWARE GDI scale before opening the either dialogs since windows has issues with dialog scaling in AWARE context
HOW TO TEST
ControlExamplewith the following VM ArgumentsBefore Fix
Case: Primary monitor 200%, Secondary monitor 100%
100%:
200%:
After Fix
100%:
200%:
