Process events until parent shell is activated #2592
Conversation
jonahgraham
force-pushed
the
fix-unstable-test
branch
2 times, most recently
from
d27585a to
ffba498
Compare
|
Test commit with |
Test Results 118 files ±0 118 suites ±0 11m 53s ⏱️ ±0s Results for commit 6777ba1. ± Comparison against base commit 1eabfa3. This pull request skips 1 test.♻️ This comment has been updated with latest results. |
jonahgraham
force-pushed
the
fix-unstable-test
branch
2 times, most recently
from
8cc0c1c to
50a12a5
Compare
|
The test I am modifying was a regression test for https://bugs.eclipse.org/bugs/show_bug.cgi?id=436841, but only tested 1 of the 4 events. I added to the test all the events. The test was also written before GTK4 (???) and was disabled on non-x11. The test is now enabled on x11. I'll updated the commit message to include the above on my next push. |
The tests have successfully run 1000x, so I think this is ready to go. |
jonahgraham
force-pushed
the
fix-unstable-test
branch
from
50a12a5 to
2d0e5ac
Compare
It may take some event cycles before the parent shell that is getting focus/activation back gets the notification. Therefore wait until the Activate listener is called This test had bitrotten due to order of operation issues, see eclipse-platform#2591 for details on that. This test was a regression test for https://bugs.eclipse.org/436841, but only tested 1 of the 4 events. I added to the test all the events. The test was also written before GTK4 (???) and was disabled on non-x11. The test is now enabled on x11.
jonahgraham
force-pushed
the
fix-unstable-test
branch
from
2d0e5ac to
6777ba1
Compare
It may take some event cycles before the parent shell that is getting focus/activation back gets the notification. Therefore wait until the Activate listener is called