Update JSVG dependency to 2.0.0 #2597
Conversation
|
FYI, this build needed to finish to make the TP changes available: https://ci.eclipse.org/platform/job/eclipse.platform.releng.aggregator/job/master/3818/changes |
Yeah, thanks! I saw that I was just too fast with the follow-up 🙂 |
|
Do we need a minor version bump of a bundle/fragment when we update the major version of one of it's dependencies? I.e., do we need to bump minor version of the SVG fragment because we make a major bump of the JSVG dependency? I do not find specific information about the case in our guidelines: https://github.com/eclipse-platform/eclipse.platform/blob/master/docs/VersionNumbering.md |
|
Most recently major updates of 3rd party deps have been Lucene and Jetty - in both cases major version of the bundle requiring them wasn't bumped. So only a minor bump is what I would recommend. |
|
A minor version bump seems appropriate. |
Thank you! That aligns with what I would do if in doubt. Just because I wasn't completely precise in my question: I did actually not think about major vs. minor version bump of the fragment but rather about minor vs. service version bump. I have adapted the PR to bump the minor version of the fragment. |
|
Last time fragments bundle versions were changed without SWT change and that caused eclipse-platform/eclipse.platform.releng.aggregator#3347 Could it be, all SWT fragments & bundle versions need to be touched now? |
In my understanding, that should only be the case for the (actually non-optional) native fragments. This change one affects the SVG fragment which is fully optional, which is also why it's not bumped together with all the other fragments and the host. So I expect no issues with only bumping the SVG fragment version. |
No description provided.