Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GTK4] Call gtk_window_destroy if widget to be destroyed is a GtkWindow #50

Merged
merged 1 commit into from
Apr 17, 2022
Merged

[GTK4] Call gtk_window_destroy if widget to be destroyed is a GtkWindow #50

merged 1 commit into from
Apr 17, 2022

Conversation

joel-majano
Copy link
Contributor

@joel-majano joel-majano commented Apr 14, 2022 •
edited
Loading

Previously, when the dialog was closed in Snippet 50, an swt_fixed_remove assertion error was logged in the console (issue #49). With this patch that no longer happens.

  • added a call to gtk_window_destroy which happens only if GTK_IS_WINDOW is true.

Tested using Snippet 50.

@sravanlakkimsetti sravanlakkimsetti linked an issue Apr 17, 2022 that may be closed by this pull request
[GTK4] Snippet 50 swt_fixed_remove error when closing dialog #49
Closed
@sravanlakkimsetti sravanlakkimsetti merged commit 092be33 into eclipse-platform:master Apr 17, 2022
@joel-majano joel-majano deleted the swtFixedError-1 branch April 20, 2022 15:06
@joel-majano
Copy link
Contributor Author

Sravan, thanks for the merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sravanlakkimsetti sravanlakkimsetti sravanlakkimsetti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[GTK4] Snippet 50 swt_fixed_remove error when closing dialog
2 participants
@joel-majano @sravanlakkimsetti