Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement filter-based TableViewer as a counterpart to the FilteredTree #2567

Merged
merged 1 commit into from
Jan 24, 2025
+1,030 −7
Merged

Implement filter-based TableViewer as a counterpart to the FilteredTree #2567

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading status checks…
Implement filter-based TableViewer as a counterpart to the FilteredTree 
Projects such as PDE currently use the FilteredTree in combination with
a child-less ITreeContentProvider to simulate a filtered table.

This approach brings a big performance overhead, as the tree still has
to handle functionality such as expansion and contraction of the (flat)
tree structure which especially large trees/tables causes a significant
problems.
@ptziegler
ptziegler committed Jan 23, 2025
commit 9a4aa7a5b7ad072ed690d9ac0fd6e0da74c590e9
11 changes: 11 additions & 0 deletions bundles/org.eclipse.e4.ui.dialogs/.settings/.api_filters
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<component id="org.eclipse.e4.ui.dialogs" version="2">
<resource path="src/org/eclipse/e4/ui/dialogs/filteredtree/FilteredTable.java" type="org.eclipse.e4.ui.dialogs.filteredtree.FilteredTable$NotifyingTableViewer">
<filter id="571473929">
<message_arguments>
<message_argument value="TableViewer"/>
<message_argument value="NotifyingTableViewer"/>
</message_arguments>
</filter>
</resource>
</component>
Comment on lines +1 to +11
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how to handle the API warning because the UI bundles are implementing the JFace viewers directly (just like the existing FilteredTree does).
Reason being that the filter cache is not properly cleared when e.g. a node is no longer filtered. See https://bugs.eclipse.org/bugs/show_bug.cgi?id=187200

Loading