Clean Code for bundles/org.eclipse.jface.text

[eclipse-platform-bot]

The following cleanups were applied:

• Add final modifier to private fields
• Add missing '@Deprecated' annotations
• Add missing '@Override' annotations
• Add missing '@Override' annotations to implementations of interface methods
• Convert control statement bodies to block
• Make inner classes static where possible
• Remove trailing white spaces on all lines
• Remove unnecessary array creation for varargs
• Remove unnecessary suppress warning tokens
• Remove unused imports
• Remove unused private constructors
• Remove unused private fields
• Remove unused private methods
• Remove unused private types
• Replace deprecated calls with inlined content where possible
• Use pattern matching for instanceof

[github-actions]

Test Results

 3 018 files  ±0   3 018 suites  ±0   2h 40m 50s ⏱️ + 12m 3s
 8 226 tests ±0   7 976 ✅ ±0  249 💤 ±0  1 ❌ ±0 
23 598 runs  ±0  22 803 ✅ ±0  794 💤 ±0  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit 7debe58. ± Comparison against base commit 300636b.

♻️ This comment has been updated with latest results.

[akurtakov]

@laeubi This is simply non reviewable (even according to Github UI). Is there a way to run smaller set of changes for this bundle or should it be done manually so we got a PR that can actually be reviewed?

[vogella]

@akurtakov I think most of these changes are "Convert control statement bodies to block". I run this clean-up manually and push it in smaller batches so that this becomes reviewable.

[vogella]

Ups, sorry, clicked the default (merge) instead of the rebase. I can update this later tonight and remove the merge commit.

@akurtakov is it possible to disable the "Update with merge" option from the webui?

[akurtakov]

No idea .

[vogella]

Has been updated by the bot