Migrate WorkbenchContextRule to JUnit 5 #3501
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated WorkbenchContextRule from JUnit 4 MethodRule to JUnit 5 Extension by implementing BeforeEachCallback, AfterEachCallback, and TestInstancePostProcessor interfaces. Updated all tests using WorkbenchContextRule to JUnit 5: - Changed @rule to @RegisterExtension - Updated imports from org.junit to org.junit.jupiter.api - Changed Assert to Assertions - Changed Assume to Assumptions - Changed @before to @beforeeach - Changed @ignore to @disabled Files updated: - WorkbenchContextRule.java (rule implementation) - MMenuItemTest.java - MWindowTest.java - MPartTest.java - ModelServiceImplTest.java - MToolItemTest.java - MSaveablePartTest.java - CompositePartClosingTest.java - PartRenderingEngineTests.java - PartOnTopManagerTest.java - MenuManagerRendererTest.java - ToolBarManagerRendererTest.java - StackRendererTest.java
Contributor
Test Results 2 865 files - 153 2 865 suites - 153 2h 15m 37s ⏱️ - 2m 29s For more details on these failures, see this check. Results for commit 1cd6953. ± Comparison against base commit 9c171a0. This pull request removes 992 tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated WorkbenchContextRule from JUnit 4 MethodRule to JUnit 5 Extension by implementing BeforeEachCallback, AfterEachCallback, and TestInstancePostProcessor interfaces.
Updated all tests using WorkbenchContextRule to JUnit 5:
Files updated: