Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move TextMatcher from Platform UI to Platform Core Resources #1650

Closed
wants to merge 2 commits into from

Conversation

ptziegler
Copy link
Contributor

The TextMatcher class is used in the UI component, despite not depending on any UI classes. By moving it to the platform, it can be used in both mixed and pure E4 applications.

The TextMatcher class is used in the UI component, despite not depending
on any UI classes. By moving it to the platform, it can be used in both
mixed and pure E4 applications.
@ptziegler
Copy link
Contributor Author

Prerequisite to eclipse-platform/eclipse.platform.ui#2567

@eclipse-platform-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

resources/tests/org.eclipse.core.tests.resources/META-INF/MANIFEST.MF
resources/tests/org.eclipse.core.tests.resources/pom.xml

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From b2c7feb562bf0296bf20bb4070f9e674520defee Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Thu, 12 Dec 2024 19:51:15 +0000
Subject: [PATCH] Version bump(s) for 4.35 stream


diff --git a/resources/tests/org.eclipse.core.tests.resources/META-INF/MANIFEST.MF b/resources/tests/org.eclipse.core.tests.resources/META-INF/MANIFEST.MF
index cbb54734ff..9f542ab492 100644
--- a/resources/tests/org.eclipse.core.tests.resources/META-INF/MANIFEST.MF
+++ b/resources/tests/org.eclipse.core.tests.resources/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: Eclipse Core Tests Resources
 Bundle-SymbolicName: org.eclipse.core.tests.resources; singleton:=true
-Bundle-Version: 3.11.700.qualifier
+Bundle-Version: 3.11.800.qualifier
 Bundle-Vendor: Eclipse.org
 Export-Package: org.eclipse.core.tests.filesystem,
  org.eclipse.core.tests.internal.alias,
diff --git a/resources/tests/org.eclipse.core.tests.resources/pom.xml b/resources/tests/org.eclipse.core.tests.resources/pom.xml
index 44f9740e18..d5293064bf 100644
--- a/resources/tests/org.eclipse.core.tests.resources/pom.xml
+++ b/resources/tests/org.eclipse.core.tests.resources/pom.xml
@@ -18,7 +18,7 @@
     <version>4.35.0-SNAPSHOT</version>
   </parent>
   <artifactId>org.eclipse.core.tests.resources</artifactId>
-  <version>3.11.700-SNAPSHOT</version>
+  <version>3.11.800-SNAPSHOT</version>
   <packaging>eclipse-test-plugin</packaging>
 
   <properties>
-- 
2.47.1

Further information are available in Common Build Issues - Missing version increments.

Copy link
Contributor

Test Results

 1 758 files  + 3   1 758 suites  +3   1h 35m 6s ⏱️ + 1m 20s
 4 176 tests + 6   4 154 ✅ + 6   22 💤 ±0  0 ❌ ±0 
13 125 runs  +18  12 961 ✅ +18  164 💤 ±0  0 ❌ ±0 

Results for commit 3cbf959. ± Comparison against base commit 5d8ee71.

Copy link
Contributor

@vogella vogella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this class be used from other plugins? In this case please use a non internal package

@ptziegler
Copy link
Contributor Author

ptziegler commented Dec 12, 2024

Should this class be used from other plugins? In this case please use a non internal package

That's the plan, at least. But I haven't found any good place to put it... Perhaps this really needs to be pushed down to Equinox.

Edit: eclipse-equinox/equinox#720

@ptziegler ptziegler closed this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants