Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-4809 Performance improvements to the iterations #4810

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

hmottestad
Copy link
Contributor

GitHub issue resolved: #4809

Briefly describe the changes proposed in this PR:


PR Author Checklist (see the contributor guidelines for more details):

  • my pull request is self-contained
  • I've added tests for the changes I made
  • I've applied code formatting (you can use mvn process-resources to format from the command line)
  • I've squashed my commits where necessary
  • every commit message starts with the issue number (GH-xxxx) followed by a meaningful description of the change

@hmottestad
Copy link
Contributor Author

hmottestad commented Oct 12, 2023

Before

Benchmark                                                     Mode  Cnt     Score    Error  Units
QueryBenchmark.complexQuery                                   avgt    5     1.492 ±  0.032  ms/op
QueryBenchmark.different_datasets_with_similar_distributions  avgt    5     0.767 ±  0.021  ms/op
QueryBenchmark.groupByQuery                                   avgt    5     0.966 ±  0.040  ms/op
QueryBenchmark.long_chain                                     avgt    5   260.424 ±  8.599  ms/op
QueryBenchmark.lots_of_optional                               avgt    5    54.358 ±  0.439  ms/op
QueryBenchmark.minus                                          avgt    5  2350.765 ± 16.433  ms/op
QueryBenchmark.nested_optionals                               avgt    5    74.068 ±  0.110  ms/op
QueryBenchmark.pathExpressionQuery1                           avgt    5     8.003 ±  0.123  ms/op
QueryBenchmark.pathExpressionQuery2                           avgt    5     1.116 ±  0.033  ms/op
QueryBenchmark.query_distinct_predicates                      avgt    5    73.386 ±  0.367  ms/op
QueryBenchmark.simple_filter_not                              avgt    5     3.237 ±  0.061  ms/op

After

Benchmark                                                     Mode  Cnt     Score   Error  Units
QueryBenchmark.complexQuery                                   avgt    5     1.330 ± 0.006  ms/op
QueryBenchmark.different_datasets_with_similar_distributions  avgt    5     0.615 ± 0.002  ms/op
QueryBenchmark.groupByQuery                                   avgt    5     0.984 ± 0.243  ms/op
QueryBenchmark.long_chain                                     avgt    5   198.337 ± 2.056  ms/op
QueryBenchmark.lots_of_optional                               avgt    5    55.765 ± 2.690  ms/op
QueryBenchmark.minus                                          avgt    5  1084.976 ± 8.501  ms/op
QueryBenchmark.nested_optionals                               avgt    5    69.339 ± 0.199  ms/op
QueryBenchmark.pathExpressionQuery1                           avgt    5     6.978 ± 0.047  ms/op
QueryBenchmark.pathExpressionQuery2                           avgt    5     1.120 ± 0.043  ms/op
QueryBenchmark.query_distinct_predicates                      avgt    5    71.958 ± 2.759  ms/op
QueryBenchmark.simple_filter_not                              avgt    5     2.674 ± 0.011  ms/op

Benchmark                                                     Mode  Cnt     Score    Error  Units
QueryBenchmark.complexQuery                                   avgt    5     1.337 ±  0.010  ms/op
QueryBenchmark.different_datasets_with_similar_distributions  avgt    5     0.605 ±  0.003  ms/op
QueryBenchmark.groupByQuery                                   avgt    5     0.924 ±  0.194  ms/op
QueryBenchmark.long_chain                                     avgt    5   186.587 ±  4.362  ms/op
QueryBenchmark.lots_of_optional                               avgt    5    52.769 ±  1.092  ms/op
QueryBenchmark.minus                                          avgt    5  1105.970 ± 17.679  ms/op
QueryBenchmark.nested_optionals                               avgt    5    68.153 ±  4.593  ms/op
QueryBenchmark.pathExpressionQuery1                           avgt    5     7.052 ±  0.610  ms/op
QueryBenchmark.pathExpressionQuery2                           avgt    5     1.125 ±  0.009  ms/op
QueryBenchmark.query_distinct_predicates                      avgt    5    64.641 ±  3.559  ms/op
QueryBenchmark.simple_filter_not                              avgt    5     3.275 ±  0.485  ms/op
Benchmark                                                     Mode  Cnt     Score    Error  Units
QueryBenchmark.complexQuery                                   avgt   15     1.332 ±  0.039  ms/op
QueryBenchmark.different_datasets_with_similar_distributions  avgt   15     0.624 ±  0.006  ms/op
QueryBenchmark.groupByQuery                                   avgt   15     0.930 ±  0.044  ms/op
QueryBenchmark.long_chain                                     avgt   15   207.963 ±  8.816  ms/op
QueryBenchmark.lots_of_optional                               avgt   15    53.982 ±  0.829  ms/op
QueryBenchmark.minus                                          avgt   15  1093.575 ± 19.799  ms/op
QueryBenchmark.nested_optionals                               avgt   15    60.276 ±  0.972  ms/op
QueryBenchmark.pathExpressionQuery1                           avgt   15     7.688 ±  0.213  ms/op
QueryBenchmark.pathExpressionQuery2                           avgt   15     1.143 ±  0.021  ms/op
QueryBenchmark.query_distinct_predicates                      avgt   15    66.576 ±  1.820  ms/op
QueryBenchmark.simple_filter_not                              avgt   15     2.850 ±  0.065  ms/op

@hmottestad hmottestad force-pushed the GH-4809-iterations-performance branch from 597688b to 885bb08 Compare October 15, 2023 15:06
@hmottestad hmottestad merged commit 8e7c2c0 into develop Oct 16, 2023
7 checks passed
@hmottestad hmottestad deleted the GH-4809-iterations-performance branch October 16, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant