GH-4817 LMDB: Make close method of LmdbRecordIterator thread-safe. #4818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…read-safe. Ensures that a lock is used if close() is called asynchronously from another thread than next().
|
@hmottestad Is it expected that the Elasticsearch test fails? |
|
They have been failing a lot lately. I think that those tests use the elasticsearch testing harness that is internal to Elastic and not meant for public usage. I don't really know what has changed to make them start failing now though. |
|
I'm rerunning it now to see if it passes the second time around. That's been my experience at least. |
|
Could be because I've updated the surefire and failsafe maven plugins. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that a lock is used if close() is called asynchronously from another thread than next().
GitHub issue resolved: #4817
Briefly describe the changes proposed in this PR:
Ensures that close method does not interfere next if called asynchronously from another thread.
PR Author Checklist (see the contributor guidelines for more details):
mvn process-resourcesto format from the command line)