Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main into develop #4912

Merged
merged 14 commits into from
Feb 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/develop-status.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
jdk: [11, 21]
jdk: [11, 17]

steps:
- uses: actions/checkout@v2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/main-status.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
jdk: [11, 21]
jdk: [11, 17]

steps:
- uses: actions/checkout@v2
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,14 @@
public class RDFaParserSettings {

/**
* Boolean setting for parser to determine the RDFa version to use when processing the document.
* <p>
* Defaults to {@link RDFaVersion#RDFA_1_0}.
* Boolean setting for parser to determine the RDFa version to use when processing the document. Note that although
* these settings are not used within RDF4J, they are in use by external plugins.
*
* @see <a href=
* "https://github.com/eclipse-rdf4j/rdf4j/issues/4779">https://github.com/eclipse-rdf4j/rdf4j/issues/4779</a>
* <p>
* Defaults to {@link RDFaVersion#RDFA_1_0}.
*/
@Deprecated(since = "4.3.0", forRemoval = true)
public static final RioSetting<RDFaVersion> RDFA_COMPATIBILITY = new RioSettingImpl<>(
"org.eclipse.rdf4j.rio.rdfa.version", "RDFa Version Compatibility", RDFaVersion.RDFA_1_0);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,14 @@
package org.eclipse.rdf4j.rio.helpers;

/**
* Enumeration for tracking versions of the RDFa specification to specify processing capabilities of RDFa modules.
* Enumeration for tracking versions of the RDFa specification to specify processing capabilities of RDFa modules. Note
* that although these settings are not used within RDF4J, they are in use by external plugins.
*
* @see <a href=
* "https://github.com/eclipse-rdf4j/rdf4j/issues/4779">https://github.com/eclipse-rdf4j/rdf4j/issues/4779</a>
*
* @author Peter Ansell
*/
@Deprecated(since = "4.3.0", forRemoval = true)
public enum RDFaVersion {

/**
Expand Down
4 changes: 2 additions & 2 deletions core/sail/elasticsearch-store/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@
<plugin>
<groupId>com.github.alexcojocaru</groupId>
<artifactId>elasticsearch-maven-plugin</artifactId>
<version>6.26</version>
<version>6.28</version>
<configuration>
<skip>${skipITs}</skip>
<skip>${skipTests}</skip>
Expand All @@ -193,7 +193,7 @@
<httpPort>9200</httpPort>
<environmentVariables>
<ingest.geoip.downloader.enabled>false</ingest.geoip.downloader.enabled>
<ES_JAVA_OPTS>${java.sec.mgr} -Xmx1g</ES_JAVA_OPTS>
<ES_JAVA_OPTS>${java.sec.mgr} -Xmx1G -Xms1G</ES_JAVA_OPTS>
</environmentVariables>
<instanceCount>1</instanceCount>
<instanceSettings>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ public static ValidationReport validate(Sail dataRepo, Sail shapesRepo) {

}
shapesConnection.commit();
} catch (Exception e) {
} catch (Throwable e) {
logger.warn("Failed to read shapes", e);
throw e;
}
Expand All @@ -98,7 +98,7 @@ public static ValidationReport validate(Sail dataRepo, Sail shapesRepo) {
return performValidation(shapes, new ConnectionsGroup(verySimpleRdfsBackwardsChainingConnection, null,
null, null, new Stats(), () -> reasoner,
new ShaclSailConnection.Settings(true, true, true, IsolationLevels.NONE), true));
} catch (Exception e) {
} catch (Throwable e) {
logger.warn("Failed to validate shapes", e);
throw e;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,12 @@ public ShapeValidationContainer(Shape shape, Supplier<PlanNode> planNodeSupplier
} else {
this.planNode = planNode;
}
} catch (Exception e) {
} catch (Throwable e) {
logger.warn("Error processing SHACL Shape {}", shape.getId(), e);
logger.warn("Error processing SHACL Shape\n{}", shape, e);
if (e instanceof Error) {
throw e;
}
throw new SailException("Error processing SHACL Shape " + shape.getId() + "\n" + shape, e);
}

Expand All @@ -76,8 +81,12 @@ public ValidationResultIterator performValidation() {
try (CloseableIteration<? extends ValidationTuple, SailException> iterator = planNode.iterator()) {
validationResults = new ValidationResultIterator(iterator, effectiveValidationResultsLimitPerConstraint);
return validationResults;
} catch (Exception e) {
} catch (Throwable e) {
logger.warn("Error validating SHACL Shape {}", shape.getId(), e);
logger.warn("Error validating SHACL Shape\n{}", shape, e);
if (e instanceof Error) {
throw e;
}
throw new SailException("Error validating SHACL Shape " + shape.getId() + "\n" + shape, e);
} finally {
handlePostLogging(before, validationResults);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -450,8 +450,9 @@ public PlanNode generatePlans(ConnectionsGroup connectionsGroup, ValidationSetti
} else {
throw new ShaclUnsupportedException("Unknown validation approach: " + validationApproach);
}
} catch (RuntimeException e) {
} catch (Throwable e) {
logger.warn("Error processing SHACL Shape {}", id, e);
logger.warn("Error processing SHACL Shape\n{}", this, e);
throw new SailException("Error processing SHACL Shape " + id + "\n" + this, e);
}

Expand Down Expand Up @@ -707,7 +708,7 @@ public static List<ContextWithShape> getShapesInContext(ShapeSource shapeSource,
.map(r -> {
try {
return new ShaclProperties(r, shapeSourceWithContext);
} catch (Exception e) {
} catch (Throwable e) {
logger.warn("Error parsing shape {}", r, e);
throw new ShaclShapeParsingException(e, r);
}
Expand All @@ -720,7 +721,7 @@ public static List<ContextWithShape> getShapesInContext(ShapeSource shapeSource,
return PropertyShape.getInstance(p, shapeSourceWithContext, parseSettings, cache);
}
throw new ShaclShapeParsingException("Unknown shape type", p.getId());
} catch (Exception e) {
} catch (Throwable e) {
logger.warn("Error parsing shape {}", p.getId(), e);
if (e instanceof ShaclShapeParsingException) {
throw e;
Expand All @@ -746,6 +747,7 @@ public String toString() {
statements.setNamespace(RSX.NS);
statements.setNamespace(RDFS.NS);
statements.setNamespace(RDF.NS);
statements.setNamespace(DASH.NS);
WriterConfig writerConfig = new WriterConfig()
.set(BasicWriterSettings.PRETTY_PRINT, true)
.set(BasicWriterSettings.INLINE_BLANK_NODES, true);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ private void evaluateLazyAspect() {
validationResultIterators = null;

}
} catch (Exception e) {
} catch (Throwable e) {
logger.warn("Error evaluating lazy validation report", e);
throw e;
}
Expand All @@ -104,7 +104,7 @@ public Model asModel(Model model) {
}

return model;
} catch (Exception e) {
} catch (Throwable e) {
logger.warn("Error converting validation report to model", e);
throw e;
}
Expand Down
8 changes: 4 additions & 4 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -648,7 +648,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.11.0</version>
<version>3.12.1</version>
<configuration>
<fork>false</fork>
<encoding>utf8</encoding>
Expand Down Expand Up @@ -729,7 +729,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
<version>3.6.0</version>
<version>3.6.3</version>
<configuration>
<encoding>utf8</encoding>
<source>11</source>
Expand Down Expand Up @@ -791,7 +791,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<version>3.2.1</version>
<version>3.2.5</version>
<configuration>
<encoding>UTF-8</encoding>
<argLine>-Xmx2048M</argLine>
Expand All @@ -800,7 +800,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-failsafe-plugin</artifactId>
<version>3.2.1</version>
<version>3.2.5</version>
<configuration>
<encoding>UTF-8</encoding>
<forkCount>1</forkCount>
Expand Down
2 changes: 1 addition & 1 deletion site/content/documentation/programming/lmdb-store.md
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ Please note that the actual footprint also depends largely on the size of IRIs a
Some basic information about LMDB database and RAM sizes can be found in the
[OpenLDAP & LMDB Sizing Guide](https://3bmahv3xwn6030jbn72hlx3j-wpengine.netdna-ssl.com/wp-content/uploads/2018/08/OpenLDAP-LMDB-Sizing-Guide.pdf).

The bottom line is thatt more RAM is better. The best is to have enough RAM to accommodate the
The bottom line is that more RAM is better. The best is to have enough RAM to accommodate the

entire database or at least the database's working set.

Expand Down
Loading