-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-5064: added docker makefile for Jetty 9 #5078
GH-5064: added docker makefile for Jetty 9 #5078
Conversation
The end-to-end tests probably just build the default dockerfile. Could you have it run against both the default/current and the jetty one? |
Ah, good thinking, forgot about that |
db55020
to
7e70a2e
Compare
Workbench seems to work, but still an issue with 404 on overview.view on the server Jetty redirects the "home page" to rdf4j-server/WEB-INF/views/home/overview.view instead of rdf4j-server/home/overview.view |
e2e/run.sh
Outdated
npx playwright test | ||
|
||
cd .. | ||
cd docker | ||
./shutdown.sh | ||
done | ||
|
||
exit $? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if the test fail for tomcat but not jetty? Does it still error out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmz yes, that's on the TODO list (and it probably doesn't hurt to update the docker documentation as well...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
0bd1d7b
to
a7763bf
Compare
…d updated e2e tests Signed-off-by: Bart Hanssens <[email protected]>
bfee867
to
f7566d0
Compare
GitHub issue resolved: #5064
Briefly describe the changes proposed in this PR:
PR Author Checklist (see the contributor guidelines for more details):
mvn process-resources
to format from the command line)