Implement Covesa CV Forwarder #48
Conversation
… positional values and implement CurveLogActor
…vider-fms and use the default data source
…Writer, build_snapshot/header_measurement functions inside the covesa-cv-forwarder component
…nted but unavailable due to current incompatible rustc toolchain 1.75.0 vs 1.79.0) and remove docker-compose.yaml
.gitignore
Outdated
| @@ -1,4 +1,4 @@ | |||
| # SPDX-FileCopyrightText: 2023 Contributors to the Eclipse Foundation | |||
| # SPDX-FileCopyrightText: 2025 Contributors to the Eclipse Foundation | |||
DEPENDENCIES
Outdated
There was a problem hiding this comment.
Where is the DEPENDENCIES file? It is required and needs to contain the result of the latest run of the dash tool
There was a problem hiding this comment.
I discarded it because I thought of it as an accidental byproduct of git actions. I reinstated it
| @@ -1,5 +1,4 @@ | |||
|
|
|||
| Apache License | |||
| Apache License | |||
There was a problem hiding this comment.
How comes that the white space is removed? License files should never change. Possible to revert?
| pub time: u128, | ||
| } | ||
|
|
||
| #[allow(dead_code)] |
There was a problem hiding this comment.
Why do we need to allow dead code here? Obviously it is used
There was a problem hiding this comment.
I also think it must have been used however I had to add this to satisfy the compiler
| lon_datapoints: Vec<Option<f64>>, | ||
| time_speed_datapoints: VecDeque<Option<u128>>, | ||
| publisher_sender: tokio::sync::mpsc::Sender<Vec<Option<ChosenSignals>>>, | ||
| } |
| vss_data.push(data_entry); | ||
| }); | ||
| } | ||
| // loop trough dataentries to extract speed,lat,lon |
| }); | ||
| } | ||
| // loop trough dataentries to extract speed,lat,lon | ||
| // reforfm into matching statement |
| /// # Examples | ||
| /// | ||
| /// ``` | ||
| /// use clap::Command; |
There was a problem hiding this comment.
Why commenting out code snippets. Should that be removed?
|
|
||
| configs: | ||
| influxdb_init.sh: | ||
| file: "./influxdb/init-scripts/create-fms-token.sh" |
There was a problem hiding this comment.
it feels a bit weird that the covesa-cv-forwarder docker compose file contains that much occurrences of the abbreviation "fms". Possible to rename some of them? (maybe not this one as it is a shared script with the sms-forwarder)
There was a problem hiding this comment.
yeah I agree with this one as we need to abstract away from any specific standard
There was a problem hiding this comment.
I could rename them from fms to covesa
csv-provider/signalsFmsRecording.csv
Outdated
There was a problem hiding this comment.
These lines were not supposed to be deleted, I restored them.
This pr will add the Covesa CV Forwarder component which implements a forwarder based on Covesa guidelines. For now it applies an algorithm to sift through meaningful signals such as Speed, Latitude, Longitude and Timestamp.
Further changes have been applied to the docker-compose, csv-provider. Launch configurations have been also added to allow fast execution and debug of both forwarders.
A custom mapping of csv-provider files has been also created however the csv file provided by GeoTab will have to be remove so that GeoTab can contribute it themselves.