Skip to content

fix(project): Show backend conflict message with modified date when creating duplicate project #1174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(project): Show backend conflict message with modified date when creating duplicate project #1174

wants to merge 1 commit into from

Conversation

@Suhas2109
Copy link
Contributor

@Suhas2109 Suhas2109 commented Nov 3, 2025 •
edited
Loading

image

This PR improves project creation error handling.
When a duplicate project is created, the UI now displays the backend conflict message.

Example:
sw360 project with name 'DuplicateProject' already exists

@akshitjoshii akshitjoshii added needs general test needs general test Do not merge don't merge labels Nov 3, 2025
@amritkv
Copy link
Member

amritkv commented Nov 3, 2025 •
edited
Loading

image This PR improves project creation error handling. When a duplicate project is created, the UI now displays the backend conflict message along with the last modified date instead of a generic error.

Example:

sw360 project with name 'DuplicateProject' already exists (last modified on 2025-11-03)

Hey @Suhas2109 !
I think the date you are trying to display on the error banner as Last Modified, the timestamp in the response body captures the current date-time and not the actual date-time of the previous project created.

@Suhas2109 Suhas2109 force-pushed the fix/duplicateProjectErrorMessage branch from 1a8d361 to ab655b9 Compare November 4, 2025 04:45
@Suhas2109
Copy link
Contributor Author

Suhas2109 commented Nov 4, 2025 •
edited
Loading

Hi @amritkv
I’ve removed the modified date from the error banner and now display only the backend message.
On 409: banner shows the API message.

amritkv
amritkv requested changes Nov 4, 2025
View reviewed changes
@Suhas2109 Suhas2109 force-pushed the fix/duplicateProjectErrorMessage branch from 40ae777 to 6611ee2 Compare November 4, 2025 06:49
@Suhas2109
Copy link
Contributor Author

Suhas2109 commented Nov 4, 2025

Hi @amritkv
I’ve updated the changes as suggested.

amritkv
amritkv requested changes Nov 6, 2025
View reviewed changes
src/app/[locale]/projects/duplicate/[id]/components/DuplicateProject.tsx Outdated
MessageService.success(t('Your project is created'))
router.push(`/projects/detail/${data._links.self.href.split('/').at(-1)}`)
return
} if (response.status === StatusCodes.CONFLICT) {
Copy link
Member

@amritkv amritkv Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Suhas2109 !
Logically it would be great to use if - else if instead of if - if as the branches of these conditions are mutually exclusive

@Suhas2109 Suhas2109 force-pushed the fix/duplicateProjectErrorMessage branch from a797aa5 to f181745 Compare November 6, 2025 13:26
@Suhas2109
Copy link
Contributor Author

Suhas2109 commented Nov 6, 2025

Hey @amritkv
I’ve updated the conditional to use if - else if.

@Suhas2109 Suhas2109 force-pushed the fix/duplicateProjectErrorMessage branch from f181745 to 61cf4e3 Compare November 6, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amritkv amritkv amritkv requested changes

@heliocastro heliocastro Awaiting requested review from heliocastro heliocastro is a code owner

@GMishx GMishx Awaiting requested review from GMishx GMishx is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

Do not merge don't merge needs general test needs general test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Suhas2109 @amritkv @akshitjoshii