-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Rest): Adding vcs field in component update api #2383
base: main
Are you sure you want to change the base?
fix(Rest): Adding vcs field in component update api #2383
Conversation
Testing this PR |
@FarooqAftab you can implement a regex check for VCS URL before updating the component either in the service or controller class. |
fa1e318
to
eac3d45
Compare
@akshitjoshii @afsahsyeda URL Validation has been implemented , request to please test and review it once. |
Hi @afsahsyeda |
@FarooqAftab Please resolve the conflicts. |
@afsahsyeda the conflicts have been resolved. Can you please test/review this PR? |
PR still has liferay folder and not rebased with latest main causing build to fail. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FarooqAftab , please rebase the branch for testing and reviewing.
@FarooqAftab Kindly resolve the merge conflicts |
sure , will resolve it. |
@@ -405,6 +405,7 @@ struct ComponentDTO { | |||
51: optional string mailinglist, | |||
52: optional string wiki, | |||
53: optional string blog, | |||
56: optional string vcs, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the appropriate json ignore for this new field (like setVcs
)
Line 826 in dfc187d
static abstract class ComponentDTOMixin extends Component { |
Depends-on: #2408
Issue: #2376
Suggest Reviewer
How To Test?
Checklist
Must: