Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix window maximization when using splash screen #14219

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix window maximization when using splash screen #14219

wants to merge 1 commit into from

Commits on Sep 25, 2024

  1. Fix window maximization when using splash screen 

    Avoid eager restore of maximized state in `TheiaElectronWindow.init`
when a splash screen is configured (i.e. `preventAutomaticShow` config
option is false)
Calling `window.maximize()` implicity also makes the window visibile.
If `preventAutomaticShow` is true we have to make sure to invoke
`restoreMaximizeState` after the main window is ready.
Otherwise both the splashscreen and the preload window will be visible
at the same time

Fixes eclipse-theia#14218
    @tortmayr
    tortmayr committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    d969dc1 View commit details
    Browse the repository at this point in the history