Improve widget specific status bar handling #14239
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Closes #14045
Adds a new dedicated
WidgetStatusBarService
(and associatedWidgetStatusBarContribution
) that enables showing status bar items for the currently selected widget.If no
WidgetStatusBarContribution
matches the current widget (like if the Explorer was selected), the previous status bar items stay. If another widget like the notebook editor gains focus, the correct contribution is selected and the new status bar items are shown.Some specific widgets (webview, custom editor, preferences, getting started, etc.) in vscode hide the previous status bar items. For this, we implement a
noopWidgetStatusBarContribution
function to enable easier disabling of status bar items.How to test
Review checklist
Reminder for reviewers