Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update keytar and drivelist #14306

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update keytar and drivelist #14306

wants to merge 3 commits into from

Conversation

JonasHelming
Copy link
Contributor

fixed #14305

Review checklist

Reminder for reviewers

@JonasHelming JonasHelming marked this pull request as draft October 13, 2024 14:47
@JonasHelming
Copy link
Contributor Author

@msujew Do you know how to test the features using keytar and drivelist? Could you take over finishing this PR?

@JonasHelming
Copy link
Contributor Author

@msujew :-)

@msujew msujew marked this pull request as ready for review December 2, 2024 16:36
@msujew
Copy link
Member

msujew commented Dec 2, 2024

@JonasHelming I've rebased the changes and added some more tests to ensure that everything works as expected. Now we need a reviewer :)

@msujew msujew added the dependencies pull requests that update a dependency file label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsmaeder tsmaeder Awaiting requested review from tsmaeder

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
dependencies pull requests that update a dependency file
Projects
PR Backlog
Status: Waiting on reviewers
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove dependency to [email protected]
2 participants
@JonasHelming @msujew