Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Enable continue command if the debbuger is active for pressing F5 #14641

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

laemmleint
Copy link

@laemmleint laemmleint commented Dec 17, 2024

What it does

This PR should solve the problem with the F5 key binding -> Issue: #14639
By default the key f5 is registered to "start debugging", "continue" and "refresh/reload" (if it is a browser app).

The desired behavior should be as follows:

  • No debugger is started, then F5 starts the debugger
  • The debugger is started, then only 'continue' works

In none of the cases should F5 result in a reload of the application if it is running in a web browser.

All other shortcuts should continue to work.

How to test

With the suggestion fix
8ec7557
the behaviour is much better while press and hold the F5 key.

press_and_hold_f5_suggestion_fix

Follow-ups

Breaking changes

Attribution

Contributed by MVTec Software GmbH

Review checklist

As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

@tsmaeder tsmaeder requested a review from msujew December 25, 2024 09:14
@tsmaeder
Copy link
Contributor

While the enablement of the "continue" action is more correct with this PR, aren't both keybindings still active and it's basically random whether "start" or "continue" are being executed when both are possible?

@msujew
Copy link
Member

msujew commented Dec 25, 2024

@tsmaeder I believe so as well, see the discussion over at #14639.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Waiting on reviewers
Development

Successfully merging this pull request may close these issues.

3 participants