Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix updating breakpoints when debugging starts #14645

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mvtec-richter
Copy link

What it does

Previously, when starting to debug, the breakpoints did not move to valid lines. The breakpoints were send to the debug adapter before configurationDone and some debug adapters (e. g. python) return updated positions directly. The updates were not visible in the editor, because the connection was not marked as initialized yet and events were ignored. The updates became only visible, when changing breakpoints later.

Fixes #14096

How to test

  • Write a small python program with empty lines.
  • Set a breakpoint on an empty line and another line above
  • Start debugging, the program should stop at the first breakpoint
    Now fixed:
  • The breakpoint on the empty line should move to a valid line

Follow-ups

Breaking changes

  • This PR introduces breaking changes and requires careful review. If yes, the breaking changes section in the changelog has been updated.

Attribution

Contributed by MVTec Software GmbH

Review checklist

Reminder for reviewers

Previously, when starting to debug, the breakpoints did not
move to valid lines. The breakpoints were send to the debug
adapter before configurationDone and some debug adapters
(e. g. python) return updated positions directly. The updates
were not visible in the editor, because the connection was not
marked as initialized yet and events were ignored. The
updates became only visible, when changing breakpoints later.
This commit fixes this.

Fixes eclipse-theia#14096

Signed-off-by: Florian Richter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Waiting on reviewers
Development

Successfully merging this pull request may close these issues.

Breakpoint markers are not updated when debugging starts
1 participant