Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser-only file search #14806

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

robertjndw
Copy link
Contributor

What it does

Currently, browser-only file search was not possible due to the lack of @vscode/ripgrep in an environment without Node support. This PR implements file search using the browser-only FileSystemProvider and minimatch.
This implementation was necessary because some VSCode API weren't working correctly for Web Extensions (e.g. vscode.workspace.findFiles())

How to test

  1. Open a in-browser Project multiple files
  2. Hit CMD + P to open the file search
  3. Enter a file name or a pattern

Follow-ups

The workspace search is currently not working for a similar problem as it uses @vscode/ripgrep too.

Breaking changes

  • This PR introduces breaking changes and requires careful review. If yes, the breaking changes section in the changelog has been updated.

Attribution

Review checklist

Reminder for reviewers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Waiting on reviewers
Development

Successfully merging this pull request may close these issues.

1 participant