Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Currently, browser-only file search was not possible due to the lack of
@vscode/ripgrep
in an environment without Node support. This PR implements file search using the browser-only FileSystemProvider andminimatch
.This implementation was necessary because some VSCode API weren't working correctly for Web Extensions (e.g.
vscode.workspace.findFiles()
)How to test
CMD + P
to open the file searchFollow-ups
The workspace search is currently not working for a similar problem as it uses
@vscode/ripgrep
too.Breaking changes
Attribution
Review checklist
Reminder for reviewers