Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update vscode-oniguruma+vscode-textmate #14848

Merged
merged 1 commit into from
Feb 14, 2025
Merged

chore: update vscode-oniguruma+vscode-textmate #14848

merged 1 commit into from
Feb 14, 2025

Conversation

kittaakos
Copy link
Contributor

What it does

This PR updates the dependencies to [email protected] and [email protected].

Closes #8309

How to test

I verified a few languages with the browser and the electron examples.

I did not find any breaking likes in the changelogs:

Screen.Recording.2025-02-05.at.16.49.57.mov
Screen.Recording.2025-02-05.at.16.48.03.mov

Follow-ups

Breaking changes

  • This PR introduces breaking changes and requires careful review. If yes, the breaking changes section in the changelog has been updated.

Attribution

Review checklist

Reminder for reviewers

sdirix
sdirix requested changes Feb 13, 2025
View reviewed changes
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! I didn't see any regression in Browser or Electron.

However one adaption in this PR seems unnecessary and potentially dangerous if it gets out of sync with the lib.

packages/plugin-ext/src/main/browser/plugin-contribution-handler.ts Show resolved Hide resolved
@sdirix
Copy link
Member

sdirix commented Feb 13, 2025

@msujew you also want to take a look?

msujew
msujew approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me as well 👍

@msujew msujew added monaco issues related to monaco dependencies pull requests that update a dependency file labels Feb 13, 2025
@sdirix sdirix merged commit c854b8f into eclipse-theia:master Feb 14, 2025
11 checks passed
@github-actions github-actions bot added this to the 1.59.0 milestone Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msujew msujew msujew approved these changes

@sdirix sdirix sdirix approved these changes

Assignees
No one assigned
Labels
dependencies pull requests that update a dependency file monaco issues related to monaco
Projects
PR Backlog
Status: Done
Milestone
1.59.0
Development

Successfully merging this pull request may close these issues.

upgrade to latest oniguruma
3 participants
@kittaakos @sdirix @msujew