Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disabling csharp.tmLanguage which uses unsupported syntax #678

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion org.eclipse.tm4e.language_pack/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ for the [Eclipse IDE](https://eclipseide.org).
| Batch File <img src="syntaxes/bat/bat.png" width=16/> | file-extensions="bat, cmd" | [1.85.2@microsoft/vscode](https://github.com/microsoft/vscode/tree/8b3775030ed1a69b13e4f4c628c612102e30a681/extensions/bat) [[upstream]](https://github.com/mmims/language-batchfile/commit/6154ae25a24e01ac9329e7bcf958e093cd8733a9)
| BibTeX | file-extensions="bib" | [1.85.2@microsoft/vscode](https://github.com/microsoft/vscode/tree/8b3775030ed1a69b13e4f4c628c612102e30a681/extensions/latex) [[upstream]](https://github.com/jlelong/vscode-latex-basics/commit/36411b38cf4ed18e02050249e2162b1316488686)
| C | file-extensions="c, i" | [1.85.2@microsoft/vscode](https://github.com/microsoft/vscode/tree/8b3775030ed1a69b13e4f4c628c612102e30a681/extensions/cpp) [[upstream]](https://github.com/jeff-hykin/better-c-syntax/commit/34712a6106a4ffb0a04d2fa836fd28ff6c5849a4)
| C# | file-extensions="cake, cs, csx" | [1.85.2@microsoft/vscode](https://github.com/microsoft/vscode/tree/8b3775030ed1a69b13e4f4c628c612102e30a681/extensions/csharp) [[upstream]](https://github.com/dotnet/csharp-tmLanguage/commit/6666eb1d5e6fb565a4110d6db645cc534fb3c6d2)
| C++ | file-extensions="c++, cc, cpp, cxx, h, h++, h.in, hh, hpp, hpp.in, hxx, ii, inl, ino, ipp, ixx, tpp, txx" | [1.85.2@microsoft/vscode](https://github.com/microsoft/vscode/tree/8b3775030ed1a69b13e4f4c628c612102e30a681/extensions/cpp) [[upstream]](https://github.com/jeff-hykin/better-cpp-syntax/commit/f1d127a8af2b184db570345f0bb179503c47fdf6)
| Clojure <img src="syntaxes/clojure/clojure.png" width=16/> | file-extensions="clj, cljc, cljs, cljx, clojure, edn" | [1.85.2@microsoft/vscode](https://github.com/microsoft/vscode/tree/8b3775030ed1a69b13e4f4c628c612102e30a681/extensions/clojure) [[upstream]](https://github.com/atom/language-clojure/commit/45bdb881501d0b8f8b707ca1d3fcc8b4b99fca03)
| Code Snippets | file-extensions="code-snippets"<br />file-patterns="\*\*/User/profiles/\*/snippets/\*.json, \*\*/User/snippets/\*.json" | [1.85.2@microsoft/vscode](https://github.com/microsoft/vscode/tree/8b3775030ed1a69b13e4f4c628c612102e30a681/extensions/json) [[upstream]](https://github.com/jeff-hykin/better-snippet-syntax/commit/2b1bb124cb2b9c75c3c80eae1b8f3a043841d654)
Expand Down
5 changes: 0 additions & 5 deletions org.eclipse.tm4e.language_pack/about.html
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,6 @@ <h2>About This Content</h2>
<td>file-extensions="c, i"</td>
<td><a href="https://github.com/microsoft/vscode/tree/8b3775030ed1a69b13e4f4c628c612102e30a681/extensions/cpp">1.85.2@microsoft/vscode</a> <a href="https://github.com/jeff-hykin/better-c-syntax/commit/34712a6106a4ffb0a04d2fa836fd28ff6c5849a4">[upstream]</a>
</tr>
<tr>
<td>C#</td>
<td>file-extensions="cake, cs, csx"</td>
<td><a href="https://github.com/microsoft/vscode/tree/8b3775030ed1a69b13e4f4c628c612102e30a681/extensions/csharp">1.85.2@microsoft/vscode</a> <a href="https://github.com/dotnet/csharp-tmLanguage/commit/6666eb1d5e6fb565a4110d6db645cc534fb3c6d2">[upstream]</a>
</tr>
<tr>
<td>C++</td>
<td>file-extensions="c++, cc, cpp, cxx, h, h++, h.in, hh, hpp, hpp.in, hxx, ii, inl, ino, ipp, ixx, tpp, txx"</td>
Expand Down
20 changes: 0 additions & 20 deletions org.eclipse.tm4e.language_pack/plugin.xml
Original file line number Diff line number Diff line change
Expand Up @@ -186,26 +186,6 @@
<grammar scopeName="source.c.platform" path="syntaxes/cpp/source.c.platform.tmLanguage.json" />
</extension>

<!-- ======================================== -->
<!-- csharp/csharp: C# -->
<!-- ======================================== -->
<extension point="org.eclipse.core.contenttype.contentTypes">
<content-type id="org.eclipse.tm4e.language_pack.csharp" name="C#" base-type="org.eclipse.tm4e.language_pack.basetype" priority="low"
file-extensions="cake,cs,csx" />
</extension>
<extension point="org.eclipse.tm4e.registry.grammars">
<grammar scopeName="source.cs" path="syntaxes/csharp/csharp.tmLanguage.json" />
<scopeNameContentTypeBinding scopeName="source.cs" contentTypeId="org.eclipse.tm4e.language_pack.csharp" />
</extension>

<extension point="org.eclipse.tm4e.languageconfiguration.languageConfigurations">
<languageConfiguration contentTypeId="org.eclipse.tm4e.language_pack.csharp" path="syntaxes/csharp/csharp.language-configuration.json" />
</extension>

<extension point="org.eclipse.tm4e.ui.snippets">
<snippet name="C# Example" path="syntaxes/csharp/csharp.example.cs" scopeName="source.cs" />
</extension>

<!-- ======================================== -->
<!-- css/css: CSS -->
<!-- ======================================== -->
Expand Down
7 changes: 4 additions & 3 deletions org.eclipse.tm4e.language_pack/updater/updater-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,9 @@ sources:
bat:
label: Batch File

csharp:
ignored: uses variable length look-behind not supported by joni, see https://github.com/eclipse/tm4e/issues/677

diff:
ignored: theme support required

Expand Down Expand Up @@ -136,9 +139,7 @@ sources:
ignored: 'broken, maybe because of file extension: *.log.?'

markdown-math:
ignored: >-
broken because math.block begin regex not supported by Joni. Re-enable
when the following is fixed and integrated: https://github.com/microsoft/vscode/issues/181662
ignored: uses variable length look-behind not supported by joni, see https://github.com/eclipse/tm4e/issues/677
languages:
markdown-math:
label: Markdown Math
Expand Down
15 changes: 0 additions & 15 deletions org.eclipse.tm4e.language_pack/updater/updater-state.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -93,21 +93,6 @@ extensions:
- .cuh
inline-grammars:
- source.c.platform
csharp:
github:
repo: microsoft/vscode
path: extensions/csharp
ref: 1.85.2
commit: 8b3775030ed1a69b13e4f4c628c612102e30a681
languages:
csharp:
label: C#
scope-name: source.cs
upstream-url: https://github.com/dotnet/csharp-tmLanguage/commit/6666eb1d5e6fb565a4110d6db645cc534fb3c6d2
file-extensions:
- .cake
- .cs
- .csx
css:
github:
repo: microsoft/vscode
Expand Down
Loading