Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/dcmfoss 53 #10

Merged
merged 34 commits into from
Sep 25, 2023
Merged

Feat/dcmfoss 53 #10

merged 34 commits into from
Sep 25, 2023

Conversation

Bailonis
Copy link
Contributor

In this PR we taked care about the TGR 5, the one about the Helm Charts.

Everything is up and running.

viniciusvieirah and others added 21 commits August 24, 2023 21:49
Ruskyy
Ruskyy approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@Ruskyy Ruskyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working on our side and discussed with the team.
No extra findings, unless some WoW is a miss.
Seems good

@Bailonis Bailonis requested a review from carslen September 5, 2023 15:20
@SebastianBezold
Copy link
Contributor

Hi @Bailonis,

please take care of the merge conflict that are caused (i guess by merging #9).
Also a general hint. Please thing about better PR tiltes. It should describe what feature you are adding a issue number or link do not provide these infos.
Same for commit messages. Instead of "Update file abc", describe the actual change. I.e. "provide JavaDoc for public API", "add USER command to run Docker process as non-root", or whatever your changes are

SebastianBezold
SebastianBezold suggested changes Sep 6, 2023
View reviewed changes
.github/workflows/chart-release.yml Outdated Show resolved Hide resolved
.github/workflows/chart-release.yml Outdated Show resolved Hide resolved
charts/demand-capacity-management/values.yaml Outdated Show resolved Hide resolved
charts/demand-capacity-management/values.yaml Outdated Show resolved Hide resolved
charts/demand-capacity-management/values.yaml Show resolved Hide resolved
demand-capacity-mgmt-frontend/.dockerignore Outdated Show resolved Hide resolved
index.yaml Outdated Show resolved Hide resolved
carslen
carslen reviewed Sep 14, 2023
View reviewed changes
Copy link
Contributor

@carslen carslen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve merge conflicts and refer to my comments. Please also refer to Sebastians comment regarding hard coding DB credentials (instead use postgresql`s Helm chart function of autogeneration the credentials).

charts/demand-capacity-management/values.yaml Outdated Show resolved Hide resolved
charts/demand-capacity-management/values.yaml Outdated Show resolved Hide resolved
@Bailonis
Copy link
Contributor Author

@carslen problems resolved :)

@carslen carslen merged commit b3253a9 into eclipse-tractusx:main Sep 25, 2023
@Bailonis Bailonis deleted the feat/DCMFOSS-53 branch December 15, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carslen carslen carslen left review comments

@SebastianBezold SebastianBezold SebastianBezold requested changes

@Ruskyy Ruskyy Ruskyy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Bailonis @SebastianBezold @carslen @Ruskyy @viniciusvieirah @OSousa117