Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 2nd community days contributions #102

Conversation

nitin-vavdiya
Copy link
Contributor

@nitin-vavdiya nitin-vavdiya commented Jul 3, 2024

Description

Initial contribution done with this PR.

  • Increased Deployability
  • Fixed error while saving material demand entities
  • Author names added
  • Resolved netty DNS resolution error for mac
  • TRG 8 will be taken care off with a separate PR into the Upstream Repository.

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@stephanbcbauer
Copy link
Member

@nitin-vavdiya Since you updated the DEPENDENCIES file ... you could also select the checkbox in your description. Same for copyright. Thanks for creating a new PR and getting rid of the 888 commits.

Copy link
Member

@stephanbcbauer stephanbcbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @nitin-vavdiya you can merge yourself, right?

@nitin-vavdiya
Copy link
Contributor Author

LGTM, @nitin-vavdiya you can merge yourself, right?

No, My GitHub role is not updated yet!

@stephanbcbauer stephanbcbauer merged commit a74cbf8 into eclipse-tractusx:main Jul 3, 2024
3 checks passed
@stephanbcbauer
Copy link
Member

@nitin-vavdiya thanks, merged it for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants