Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove downloaded dependency charts from tracking #43

Conversation

Bailonis
Copy link
Contributor

@Bailonis Bailonis commented Feb 1, 2024

This PR serves to help keep our project aligned with the TRGs and other open-source policies.

In this case, we have added the downloaded dependencies to the .gitignore file to fix issue #40

Copy link

gitguardian bot commented Feb 1, 2024

⚠️ GitGuardian has uncovered 14 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
8781932 Assigned Hashicorp Vault Token de5546e env View secret
8781932 Assigned Hashicorp Vault Token 1ef17da .env View secret
8781932 Assigned Hashicorp Vault Token b62de3f env View secret
8832579 Assigned Generic High Entropy Secret 46ce2c1 demand-capacity-mgmt-backend/src/main/java/org/eclipse/tractusx/demandcapacitymgmt/demandcapacitymgmtbackend/services/impl/EDCServiceImpl.java View secret
8832579 Assigned Generic High Entropy Secret 6b9100e demand-capacity-mgmt-backend/src/main/java/org/eclipse/tractusx/demandcapacitymgmt/demandcapacitymgmtbackend/services/impl/EDCServiceImpl.java View secret
8832579 Assigned Generic High Entropy Secret 7520efc demand-capacity-mgmt-backend/src/main/java/org/eclipse/tractusx/demandcapacitymgmt/demandcapacitymgmtbackend/services/impl/EDCServiceImpl.java View secret
8832579 Assigned Generic High Entropy Secret 7520efc demand-capacity-mgmt-backend/src/main/java/org/eclipse/tractusx/demandcapacitymgmt/demandcapacitymgmtbackend/services/impl/EDCServiceImpl.java View secret
8835346 Assigned Generic High Entropy Secret 4fa0cc0 charts/edc/consumer/values.yaml View secret
8835346 Assigned Generic High Entropy Secret 4fa0cc0 charts/edc/provider/values.yaml View secret
8835346 Assigned Generic High Entropy Secret b815721 charts/edc/consumer/values.yaml View secret
8835346 Assigned Generic High Entropy Secret b815721 charts/edc/provider/values.yaml View secret
9243936 Assigned Generic High Entropy Secret 6b9100e demand-capacity-mgmt-backend/src/main/java/org/eclipse/tractusx/demandcapacitymgmt/demandcapacitymgmtbackend/services/impl/EDCServiceImpl.java View secret
9243936 Assigned Generic High Entropy Secret f4884ba demand-capacity-mgmt-backend/src/main/java/org/eclipse/tractusx/demandcapacitymgmt/demandcapacitymgmtbackend/services/impl/EDCServiceImpl.java View secret
9243936 Assigned Generic High Entropy Secret 589ee63 demand-capacity-mgmt-backend/src/main/java/org/eclipse/tractusx/demandcapacitymgmt/demandcapacitymgmtbackend/services/impl/EDCServiceImpl.java View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@Bailonis Bailonis closed this Feb 1, 2024
@Bailonis Bailonis deleted the Issue-Remove-downloaded-dependency-Charts-from-tracking branch February 1, 2024 11:13
@Bailonis Bailonis restored the Issue-Remove-downloaded-dependency-Charts-from-tracking branch February 1, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants