docs|chore|fix(provisioning): Prepare release branch for final tagging. #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith the default ontop:ontop construct of the base image. so we need 'other execute' permissions on the entrypoint
Member
|
Why |
| type=semver,pattern={{major}} | ||
| type=semver,pattern={{major}}.{{minor}} | ||
| type=raw,value=1.9.5-SNAPSHOT,enable=${{ github.ref == format('refs/heads/{0}', 'main') }} | ||
| type=raw,value=1.9.8,enable=${{ github.ref == format('refs/heads/{0}', 'main') }} |
Contributor
There was a problem hiding this comment.
this should not be necessary. If the build is triggered by a tag like v1.2.3 for example, the rules above automatically create tags :1, :1.2 and :1.2.3.
The type=ref,event=branch already would create and overwrite main, in case the latest release should be used somewhere.
In general the declaration is fine though. I just think it's a lot of manual effort to always bump this by hand
SebastianBezold
approved these changes
Sep 1, 2023
Contributor
SebastianBezold
left a comment
SebastianBezold
left a comment
There was a problem hiding this comment.
👍 Just the small comment about hard-coded version tags for Docker builds, but that does not need to be addressed right now (or at all, if the manual bump is fine as solution)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Prepared all documentation and infrastructure to the v1.9.8 release (including sbom generation)
Debugged the chart testing/installation problem of provisioning agent (runAsGroup/runAsUser collides with the symbolic user names in the base image, so we need 'executable by others' permissions on the entrypoint.
WHY
TRG requires a proper release (tag)
chart testing workflow runs on error for provisioning agent.
FURTHER NOTES
fix and sbom improvements will be backported in a separate PR