Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updated Arc42 document #108

Merged
merged 5 commits into from
Feb 28, 2024

Conversation

sharathshivprasad
Copy link
Contributor

@sharathshivprasad sharathshivprasad commented Feb 26, 2024

Copy link
Contributor

@SebastianBezold SebastianBezold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sharathshivprasad,

please do not list these kind of chores in your CHANGELOG. This might hide actuall necessary information for outside viewers

CHANGELOG.md Outdated
@@ -8,6 +8,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
### Fixed
- Fixed trivy security issue CVE-2024-1597
- Fixed spring-security-core issue CVE-2024-22234
- Changed image type in ARC42 to svg.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a change I would highlight in the CHANGELOG.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure @SebastianBezold . I have removed this line. thanks

@SebastianBezold SebastianBezold merged commit 8a333ea into eclipse-tractusx:main Feb 28, 2024
3 checks passed
@SebastianBezold SebastianBezold deleted the arc42_update branch February 28, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide editable diagrams for your documentation Missing attribution for non Tractus-X logo
2 participants