-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Security issues fixes for QG #88
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you copy the history of your app CHANGELOG. I added the the 1.5.2
line to a chart CHANGELOG, because this is what I fixed.
All of the rest is already included in your top-level CHANGELOG.
And I don't know how often I have to remind you, that releases are done in Tractus-X.
You do not have a 1.5.3
. You also cannot set any date, if you do not know yet, when these releases will happen.
Add the changed you do to the unreleased section and we can set version and date, when there is actually a proper release done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed and raised new PRs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you bumping the Chart version? There is no change to the Chart
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed and raised new PRs
Hi @adkumar1, There are too many unrelated fixes in the same PR. This will make your history intransparent. |
3ef5c29
to
140766b
Compare
INSTALL.md
or inREADME.md
#85DockerHub
has all necessary information #86