Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Security issues fixes for QG #88

Closed
wants to merge 5 commits into from

Conversation

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you copy the history of your app CHANGELOG. I added the the 1.5.2 line to a chart CHANGELOG, because this is what I fixed.
All of the rest is already included in your top-level CHANGELOG.
And I don't know how often I have to remind you, that releases are done in Tractus-X.
You do not have a 1.5.3. You also cannot set any date, if you do not know yet, when these releases will happen.
Add the changed you do to the unreleased section and we can set version and date, when there is actually a proper release done

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed and raised new PRs

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you bumping the Chart version? There is no change to the Chart

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed and raised new PRs

@SebastianBezold
Copy link
Contributor

Hi @adkumar1,

There are too many unrelated fixes in the same PR. This will make your history intransparent.
Also your changes have nothing to do with Security fixes, like the title suggest.
It is definitely not the first time I have to remind you about doing dedicated PRs.
Also a recurring reminder, that you should not add version number and dates, if you don't have a release yet. If there is no release in eclipse-tractusx, then you collect stuff in "unreleased". If you cannot create release, ask a committer to create one for you and provide steps that need to be performed for it

@adkumar1
Copy link
Contributor Author

adkumar1 commented Nov 22, 2023

I will close this PR. Raised 1 by 1 PR seperately
PR #89 , #90 , #91, #92 has been opened for it in a segregative way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants