Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app&service): enable provider to decline subscription request #1171

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

tfjanjua
Copy link
Contributor

@tfjanjua tfjanjua commented Nov 21, 2024

Description

Ability for App or Service Provider to Decline the Subscription request

  • /api/apps/subscription/{subscriptionId}/decline
  • /api/services/subscription/{subscriptionId}/decline

Why

Currently this functionality not exists and its one of the requests from real users.

Issue

Ref: #1140

Corresponding IAM PR

eclipse-tractusx/portal-iam#233

Checklist

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@tfjanjua tfjanjua self-assigned this Nov 21, 2024
@tfjanjua tfjanjua added the enhancement New feature or request label Nov 21, 2024
@evegufy
Copy link
Contributor

evegufy commented Dec 13, 2024

Please resolve conflict and take care of codeql finding
@Phil91 @ntruchsess please review.

@evegufy evegufy changed the title feat(subscriptionDecline): Ability for App or Service Provider to Decline the Subscription request feat(app&service): enable provider to decline subscription request Dec 13, 2024
Copy link
Member

@Phil91 Phil91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be possible that the created migrations and the snapshot file were created with utf-8 with bom encoding. please make sure that those files are encoded with utf-8

…line the Subscription request

Ref: eclipse-tractusx#1140

- /api/apps/subscription/{subscriptionId}/decline
- /api/services/subscription/{subscriptionId}/decline
@tfjanjua tfjanjua force-pushed the feat/1140-offer-subscription-decline branch from 6bc0414 to 4084a3a Compare December 23, 2024 12:46
@tfjanjua tfjanjua requested a review from Phil91 December 23, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: IN REVIEW
Development

Successfully merging this pull request may close these issues.

3 participants