Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sd): add process steps for sd creation #1189

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(sd): add process steps for sd creation #1189

wants to merge 1 commit into from

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Nov 28, 2024

Description

  • add await response steps for the self description creation process
  • add retrigger processes for the await response steps

Why

To be able to display the current progress of the sd document recreation a await step has been added for the self description creation process

Issue

Refs: #1182

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@Phil91 Phil91 requested review from ntruchsess and evegufy November 28, 2024 12:11
@Phil91 Phil91 added this to the Release 25.03 milestone Nov 28, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
16.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 28, 2024
View reviewed changes
src/processes/Processes.Library/ManualProcessStepDataExtensions.cs
if (context.ProcessStepTypeId.HasValue)
{
context.PortalRepositories.GetInstance<IProcessStepRepository>().AttachAndModifyProcessSteps(
ModifyStepStatusRange(context.ProcessSteps.Where(step => step.ProcessStepTypeId == context.ProcessStepTypeId.Value), ProcessStepStatusId.FAILED, message));

Check warning

Code scanning / CodeQL

Dereferenced variable may be null Warning

Variable
context.ProcessStepTypeId
Loading
may be null at this access because it has a nullable type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntruchsess ntruchsess Awaiting requested review from ntruchsess

@evegufy evegufy Awaiting requested review from evegufy

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Portal
Status: No status
Milestone
Release 25.03
Development

Successfully merging this pull request may close these issues.
1 participant
@Phil91