Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E tests validation fixed #213

Conversation

ravinderkumarsap
Copy link
Contributor

@ravinderkumarsap ravinderkumarsap commented Jan 16, 2024

Description

Please describe your PR:
What does this PR introduce? :- This pull request (PR) addresses issues outlined in GitHub Issue #206, focusing on enhancing the existing End-to-End (E2E) tests.

  • Fixing Requests for Policy Creation:
    Updated the requests for creating policies (Bob_MANAGEMENT_URL and Alice_MANAGEMENT_URL) to include valid Business Partner Number (BPN) values.

  • Fixing Requests for Contract Definition Creation:
    Updated the requests for creating Contract Definitions (Bob_MANAGEMENT_URL and Alice_MANAGEMENT_URL) to use valid access policy IDs, contract policy IDs, and asset selectors.

  • Enhancements in Get All Policies and Get All Assets:
    Improved response validation for Get All Policies and Get All Assets.
    Updated validation checks to ensure accurate handling of previously created policies and assets.

  • Catalog Response Validation:
    Addressed issues in the Catalog Response validation script.
    Validated and updated tests with relative assets for improved accuracy.

  • Clean-Up:
    Removed unnecessary Postman collection variables to streamline and declutter the codebase.

Closes #206

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

Copy link
Contributor

@paullatzelsperger paullatzelsperger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me. TBH, I haven't checked all Postman RQ/RSes, but assuming they work, this can be merged.

One small thing for the future: Github supports closing keywords, pls use them. I added one to the description now, so issues get auto-closed once the PR Is merged.

@stephanbcbauer
Copy link
Member

@hemantxpatel review please :) thx

Copy link
Contributor

@hemantxpatel hemantxpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were some cosmetic issues in this PR which are fixed in the PR #255.

@ravinderkumarsap , there's some merge conflict. Please resolve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Fix Existing E2E Tests
4 participants