Make the slicing options of the mirror-target-platform mojo configurable #3515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laeubi
added
the
backport-to-tycho-4.0.x
tivervac
reviewed
Feb 16, 2024
p2-maven-plugin/src/main/java/org/eclipse/tycho/p2maven/SlicingOptions.java
Outdated
Show resolved
Hide resolved
p2-maven-plugin/src/main/java/org/eclipse/tycho/p2maven/SlicingOptions.java
Outdated
Show resolved
Hide resolved
p2-maven-plugin/src/main/java/org/eclipse/tycho/p2maven/SlicingOptions.java
Show resolved
Hide resolved
Test Results 588 files 588 suites 3h 55m 7s ⏱️ For more details on these failures, see this check. Results for commit 24fcc16. ♻️ This comment has been updated with latest results. |
Currently the mirror-target-platform mirrors everything it could gather, that could probably be to much, one maybe even want to configure even more things like optional dependencies. This now adds a new <options> parameter that allows to fine tune the slicing options used for mirror the target.
laeubi
force-pushed
the
make_mirror_target_configurable
branch
from
08bf580
to
d195641
Compare
tivervac
reviewed
Feb 16, 2024
...-platform-configuration/src/main/java/org/eclipse/tycho/target/MirrorTargetPlatformMojo.java
Outdated
Show resolved
Hide resolved
...-platform-configuration/src/main/java/org/eclipse/tycho/target/MirrorTargetPlatformMojo.java
Outdated
Show resolved
Hide resolved
...-platform-configuration/src/main/java/org/eclipse/tycho/target/MirrorTargetPlatformMojo.java
Outdated
Show resolved
Hide resolved
...-platform-configuration/src/main/java/org/eclipse/tycho/target/MirrorTargetPlatformMojo.java
Outdated
Show resolved
Hide resolved
...-platform-configuration/src/main/java/org/eclipse/tycho/target/MirrorTargetPlatformMojo.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Titouan Vervack <[email protected]>
tivervac
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the mirror-target-platform mirrors everything it could gather,
that could probably be to much, one maybe even want to configure even
more things like optional dependencies.
This now adds a new
<options>parameter that allows to fine tune theslicing options used for mirror the target.