Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove publish-osgi-ee from the default life-cycle #3568

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+52 −2
Draft

Remove publish-osgi-ee from the default life-cycle #3568

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 26 additions & 1 deletion RELEASE_NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,6 @@ If `addOnlyProviding` is `true` repositories that don't provide any filtered uni
</repositoryReferenceFilter>
</configuration>
</plugin>

```

### Remove support for deployableFeature option
Expand Down Expand Up @@ -368,6 +367,32 @@ backports:
- api tools fixes
- new `tycho-eclipse-plugin`

### OSGi Execution Environment Units are no longer published by default

Previously Tycho has published so called 'Execution Environment Units' that represents the packages of the used Java version,
but this has the drawback that these units represents the packages used during the build and not represent what is actually available at runtime.
It could therefore happen that something is installed by P2 that later can't be resolved, especially since modular VMs can have any set of packages,
additional packages are exposed by the framework and so on.

Because of this there are some initiative to get rid of these generated units and let them be generated at runtime based on the actual VM present,
if one requires previous behavior (e.g. to support older Eclipse / P2 / PDE / ...) it can be enabled as follows:

```xml
<plugin>
<groupId>org.eclipse.tycho</groupId>
<artifactId>tycho-p2-publisher-plugin</artifactId>
<version>${tycho-version}</version>
<executions>
<execution>
<id>publish-osgi-ee</id>
<goals>
<goal>publish-osgi-ee</goal>
</goals>
</execution>
</executions>
</plugin>
```

## 4.0.4

Backports:
Expand Down
13 changes: 13 additions & 0 deletions tycho-its/projects/eeProfile.java11/repository/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,19 @@
<packaging>eclipse-repository</packaging>
<build>
<plugins>
<plugin>
<groupId>org.eclipse.tycho</groupId>
<artifactId>tycho-p2-publisher-plugin</artifactId>
<version>${tycho-version}</version>
<executions>
<execution>
<id>publish-osgi-ee</id>
<goals>
<goal>publish-osgi-ee</goal>
</goals>
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.eclipse.tycho</groupId>
<artifactId>tycho-p2-director-plugin</artifactId>
Expand Down
13 changes: 13 additions & 0 deletions tycho-its/projects/eeProfile.java17/repository/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,19 @@
<executionEnvironment>JavaSE-17</executionEnvironment>
</configuration>
</plugin>
<plugin>
<groupId>org.eclipse.tycho</groupId>
<artifactId>tycho-p2-publisher-plugin</artifactId>
<version>${tycho-version}</version>
<executions>
<execution>
<id>publish-osgi-ee</id>
<goals>
<goal>publish-osgi-ee</goal>
</goals>
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.eclipse.tycho</groupId>
<artifactId>tycho-p2-director-plugin</artifactId>
Expand Down
1 change: 0 additions & 1 deletion tycho-maven-plugin/src/main/resources/META-INF/plexus/components.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,6 @@
org.apache.maven.plugins:maven-resources-plugin:${resources-plugin.version}:resources
</process-resources>
<prepare-package>
org.eclipse.tycho:tycho-p2-publisher-plugin:${project.version}:publish-osgi-ee,
org.eclipse.tycho:tycho-p2-publisher-plugin:${project.version}:publish-products,
org.eclipse.tycho:tycho-p2-publisher-plugin:${project.version}:publish-categories,
org.eclipse.tycho:tycho-p2-publisher-plugin:${project.version}:attach-artifacts,
Expand Down
Loading