Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt to new GPG Mojo #4411

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Adopt to new GPG Mojo #4411

merged 2 commits into from
Nov 6, 2024

Conversation

laeubi
Copy link
Member

@laeubi laeubi commented Nov 4, 2024

No description provided.

@dependabot
Bump org.apache.maven.plugins:maven-gpg-plugin from 3.1.0 to 3.2.7
cbcf9fa 
Bumps [org.apache.maven.plugins:maven-gpg-plugin](https://github.com/apache/maven-gpg-plugin) from 3.1.0 to 3.2.7.
- [Release notes](https://github.com/apache/maven-gpg-plugin/releases)
- [Commits](apache/maven-gpg-plugin@maven-gpg-plugin-3.1.0...maven-gpg-plugin-3.2.7)

---
updated-dependencies:
- dependency-name: org.apache.maven.plugins:maven-gpg-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024 •
edited
Loading

Test Results

  603 files  ±0    603 suites  ±0   4h 38m 20s ⏱️ + 11m 33s
  431 tests ±0    424 ✅ ±0   7 💤 ±0  0 ❌ ±0 
1 293 runs  ±0  1 271 ✅ ±0  22 💤 ±0  0 ❌ ±0 

Results for commit ebeedec. ± Comparison against base commit d4d1a78.

♻️ This comment has been updated with latest results.

@laeubi laeubi added the backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change label Nov 6, 2024
@laeubi laeubi merged commit db1d038 into eclipse-tycho:main Nov 6, 2024
16 checks passed
@eclipse-tycho-bot eclipse-tycho-bot mentioned this pull request Nov 6, 2024
Merged
@eclipse-tycho-bot
Copy link

💚 All backports created successfully

Status Branch Result
✅ tycho-4.0.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

1 similar comment
@eclipse-tycho-bot
Copy link

💚 All backports created successfully

Status Branch Result
✅ tycho-4.0.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@laeubi
Copy link
Member Author

laeubi commented Nov 6, 2024

@merks @mickaelistria I just restored the current state here, but given that maven now support BC as well by default some of the code seems redundant now and we might be able to use the maven implementation directly.

If there is anything needed for that please let me know and I'll try to propose a change upstream as done with

I think its not so valuable and probably hindering future updates when we maintain our own BC implementation here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laeubi @eclipse-tycho-bot