Don't write LIBARCHIVE.creationtime attribute in tar.gz archive entries

[HannesWell]

Fixes #2586

[laeubi]

There should be a config option to switch this behavior on/off

• for Tycho 4.x it must be on by default
• for Tycho 5.x we can decide what should be the default

[HannesWell]

There should be a config option to switch this behavior on/off

* for Tycho 4.x it must be on by default

* for Tycho 5.x we can decide what should be the default

If that's necessary get consensus I can add an option, but AFAIK an option was not added when this attribute was introduced, was it?

[laeubi]

when this attribute was introduced

This attribute was never (intentionally) introduced, we updated the library behind that and those maintainer choose for some reasons to support this "non standard" extension and add it by default. So from a compatibility point of view it only adds something new that can be ignored by a tool if desired.

No we have the other way round, that removing it might break use-cases that have relied on this, so I better like to preserve this. It would have been different if we would have never added it before but now it is there (even not added by intention) but disabling that by a config option is always possible of course.

[HannesWell]

No we have the other way round, that removing it might break use-cases that have relied on this, so I better like to preserve this. It would have been different if we would have never added it before but now it is there (even not added by intention) but disabling that by a config option is always possible of course.

Ok, then lets do it this way.
But I suggest to, for convenience to disable it by default for tycho-5 and keep the property by default for Tycho-4.
If one day tar can handle or ignore that attribute and the version that has the fix is widely adopted we can re-add it again.

[HannesWell]

@laeubi are you fine with this now?

[HannesWell]

Created the back-port with different default in

• [Backport Tycho 4.0] Don't write LIBARCHIVE.creationtime attribute in tar.gz archive entries #4428

[github-actions]

Test Results

  603 files  ±0    603 suites  ±0   3h 58m 11s ⏱️ - 33m 11s
  431 tests ±0    423 ✅  - 1   7 💤 ±0  1 ❌ +1 
1 293 runs  ±0  1 270 ✅  - 1  22 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit d080159. ± Comparison against base commit 2e98ec9.

♻️ This comment has been updated with latest results.

[laeubi]

Looks good!