-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial implementation of up-streamer-rust
- UTransport
Non-thread-safe version
#7
Initial implementation of up-streamer-rust
- UTransport
Non-thread-safe version
#7
Conversation
Paging @sophokles73, @AnotherDaniel, @evshary for your kind guidance 🤗 |
Realizing I forgot to swap out the |
Finished with this now |
…nc-broadcast so each Receiver gets what's sent by any Sender.
authors = [ | ||
"Pete LeVasseur <[email protected]>", | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this supposed to become an exhaustive list of contributors? The Eclipse Foundation considers maintaining such lists obsolete because everybody can derive it from the Git log. This might have some value for pointing out a prime contact for the project, though, if that is what you had intended to do :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh. I wonder -- should we have one or two primary points of contact for each of the projects that we put in here?
I get what you mean about keeping track of all contributors to be not needed.
] | ||
|
||
[workspace.package] | ||
rust-version = "1.66.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this aligned (and verified) with all of your upstream dependencies?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can check.
What's the best way to do this? Checking dependencies' Cargo.toml manually?
…r publishes and one for request, response, and notifications
…ete_forwarding_rule() can forward
… we receive it over the UTransport and then put in an Arc<UMessage> so when we're passing these around between channels it's only as big as a fat pointer, not as big as the entire UMessage.
9e8bbb7
to
cf2f9ab
Compare
up-streamer-rust
up-streamer-rust
- Non-thread-safe version
up-streamer-rust
- Non-thread-safe versionup-streamer-rust
- UTransport
Non-thread-safe version
Closing in favor of #8 Going to move unresolved comments over |
Hey there 👋
Based on @stevenhartley's stellar design, I reworked the in-progress first PR I had.
Looking for any feedback you may have 🙂
I suppose this would be to address #3