Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve message dispatching & small refactorings #8

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Improve message dispatching & small refactorings #8

wants to merge 3 commits into from

Conversation

jjj-vtm
Copy link

@jjj-vtm jjj-vtm commented Nov 7, 2024

Hi,

I made some small improvements dispatching messages to a listener. Basically:

  • Drop locks early, especially drop them before the dispatch ie. on_receive call
  • Dispatch is done on a separate task so that a slow listener does not slow down.
  • Todo to handle the connection drop case correctly.

Cheers,

Jan

@PLeVasseur
Copy link
Contributor

PLeVasseur commented Nov 15, 2024 •
edited
Loading

Hey @jjj-vtm -- sorry, I missed this! Can you rebase and then I can make some time to review.

@jjj-vtm
Copy link
Author

jjj-vtm commented Nov 18, 2024

No problem, I merged the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjj-vtm @PLeVasseur