Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message consumer message delivery reimplementation #5471

Merged
merged 3 commits into from
Feb 6, 2025

Conversation

vietj
Copy link
Member

@vietj vietj commented Feb 4, 2025

Motivation:

Reimplement MessageConsumer message delivery using InboundMessageChannel.

Changes:

MessageConsumer uses now an instance of InboundMessageChannel to handle message delivery. The dynamic upper bound of buffered messages becomes static to facilitate the implementation. This is a breaking change.

MessageConsumerOptions have been introduced to facilitate the configuration of a consumer, this will be back-ported to 4.5.x, in addition the dynamic buffered message upper bound will be deprecated in that branch.

@vietj vietj added this to the 5.0.0 milestone Feb 4, 2025
@vietj vietj changed the title Message consumer Message consumer message delivery reimplementation Feb 4, 2025
@vietj
Copy link
Member Author

vietj commented Feb 4, 2025

Some commits for inbound message channel improvements will be moved to a separate PR.

@vietj vietj force-pushed the message-consumer-rework-2 branch from 030b153 to 1d995b4 Compare February 4, 2025 16:30
@vietj vietj self-assigned this Feb 4, 2025
@vietj vietj force-pushed the message-consumer-rework-2 branch 3 times, most recently from f8dbc61 to 9fd8715 Compare February 5, 2025 09:10
@vietj vietj force-pushed the message-consumer-rework-2 branch 2 times, most recently from 18d02da to 7d29a9a Compare February 6, 2025 11:04
@vietj vietj marked this pull request as ready for review February 6, 2025 11:23
@vietj vietj force-pushed the message-consumer-rework-2 branch from 7d29a9a to b2e3b0c Compare February 6, 2025 11:27
@vietj vietj merged commit c5fb1b0 into master Feb 6, 2025
8 checks passed
@vietj vietj deleted the message-consumer-rework-2 branch February 6, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant