Introduce options to configure the creation of an event-bus consumer #5474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vietj
force-pushed
the
message-consumer-options
branch
from
86221f3 to
8c586ac
Compare
vietj
force-pushed
the
message-consumer-options
branch
from
8c586ac to
017fb45
Compare
…and deprecate message consumer max buffered message upper bound setter. Motivation: The event-bus message consumer has a dynamic max buffered messages upper bound. This dynamic bound makes difficult to implement the message flow and requires a custom implementation. Instead this should be configured when the consumer is created. Changes: Introduce MessageConsumerOptions that provides all the necessary details to create a consumer (address, localOnly, maxBufferedMessages). Consumer setMaxBufferedMessages is deprecated in favour of using options.
vietj
force-pushed
the
message-consumer-options
branch
from
017fb45 to
11c5e2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
MessageConsumerOptionsto configure the creation of an event-bus consumer and deprecate message consumer max buffered message upper bound setter.Motivation:
The event-bus message consumer has a dynamic max buffered messages upper bound. This dynamic bound makes difficult to implement the message flow and requires a custom implementation. Instead this should be configured when the consumer is created.
Changes:
Introduce
MessageConsumerOptionsthat provides all the necessary details to create a consumer (address,localOnly,maxBufferedMessages). ConsumersetMaxBufferedMessagesis deprecated in favour of using options.