-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracing support #625
Tracing support #625
Conversation
Pushed a new approach wiring the tracing in the client layer instead of the connection layer as the tracing cares about the client context before all. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're also missing db.url
tag, it could be added if we support exporting sqlConnectOptions
to a connection url.
vertx-sql-client/src/main/java/io/vertx/sqlclient/impl/tracing/QueryRequest.java
Show resolved
Hide resolved
vertx-sql-client/src/main/java/io/vertx/sqlclient/impl/tracing/SqlTracer.java
Outdated
Show resolved
Hide resolved
vertx-sql-client/src/main/java/io/vertx/sqlclient/impl/tracing/SqlTracer.java
Outdated
Show resolved
Hide resolved
vertx-pg-client/src/test/java/io/vertx/pgclient/TracingTest.java
Outdated
Show resolved
Hide resolved
|
It's not hard to support this after #644, |
please don't name that kind :-) |
kind is typically the name you use when you can't find a good name :-) |
I couldn't find an appropriate name for that either so I use it to show the usage 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks very good as the first version after we settle the minor changes.
@BillyYccc as for naming and tags, I believe we need to have in master a definition of the tags we are going to use commonly in this project so each tracing integration can do a mapping of such tag to its own tagging system. There are chances we will use the opentracing and/or opentelemetry list and then figure out. And then we will revisit this project for naming if required. |
I think the right name is |
Vert.x 4 supports tracing.
Fixes #653