Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update sync lockfiles to pass clippy options #252

Merged
merged 1 commit into from
Jan 14, 2025
Merged

fix: update sync lockfiles to pass clippy options #252

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion .github/workflows/sync-lockfiles.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,16 @@ jobs:
echo "value=." >> $GITHUB_OUTPUT
fi

- name: Compute clippy options
id: clippy-options
run: |
if [[ "${{ matrix.dependant }}" =~ eclipse-zenoh/zenoh-plugin-(ros2dds|dds) ]]; then
echo "value=--features stats,dynamic_plugin,dds_shm" >> $GITHUB_OUTPUT
else
echo "value=--all-features" >> $GITHUB_OUTPUT
fi


- name: Override ${{ matrix.dependant }} lockfile with Zenoh's
uses: actions/download-artifact@v4
with:
Expand All @@ -115,7 +125,7 @@ jobs:
- name: Rectify lockfile
# NOTE: Checking the package for errors will rectify the Cargo.lock while preserving
# the dependency versions fetched from source.
run: cargo clippy --manifest-path ${{ steps.crate-path.outputs.value }}/Cargo.toml --all-targets --all-features -- --deny warnings
run: cargo clippy --manifest-path ${{ steps.crate-path.outputs.value }}/Cargo.toml --all-targets ${{ steps.clippy-options.outputs.value }} --all-features -- --deny warnings

- name: Rectify lockfile for zenoh-c opaque-types
if: ${{ matrix.dependant == 'eclipse-zenoh/zenoh-c' }}
Expand Down
Loading