fix/db_creation_runtime_crash

[Charles-Schleich]

…ll_entries, get and deletion exhibiting similar behaviour

[github-actions]

PR missing one of the required labels: {'dependencies', 'bug', 'internal', 'breaking-change', 'new feature', 'enhancement', 'documentation'}

[J-Loudet]

I am not comfortable with the Tokio executor management so, from my limited understanding, I don't see any issue 👍
I will let @evshary approve

[oteffahi]

a DELETE message seems to still trigger a runtime error.

thread '<unnamed>' panicked at ~/.cargo/registry/src/index.crates.io-6f17d22bba15001f/hyper-0.14.28/src/client/connect/dns.rs:121:24:
there is no reactor running, must be called from the context of a Tokio 1.x runtime
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
fatal runtime error: Rust cannot catch foreign exceptions

[evshary]

I think we might have a more consistent to decide when to use await_task.
The reason we need await_task is that the async fn (put, del...) inside the impl trait (like Volume / Storage) can't await the async task directly. They can't get the current Runtime and need to use the Runtime inside plugins.
Therefore the better way here is that we only apply await_task to the function related to the trait Volume and Storage. Besides, we still use the normal await.

For example,
We don't need to use await_task inside get_deletion_timestamp, but use it here.

zenoh-backend-influxdb/v2/src/lib.rs

Line 522 in da692f1

if let Some(del_time) = self.get_deletion_timestamp(measurement.as_str()).await? {

We can ensure consistency in this way, and developers can easily know what we're doing.

BTW, just as @oteffahi reported, there are some missing parts in put and del

zenoh-backend-influxdb/v2/src/lib.rs

Line 522 in da692f1

if let Some(del_time) = self.get_deletion_timestamp(measurement.as_str()).await? {

zenoh-backend-influxdb/v2/src/lib.rs

Line 557 in da692f1

match self

zenoh-backend-influxdb/v2/src/lib.rs

Line 595 in da692f1

if let Err(e) = self

zenoh-backend-influxdb/v2/src/lib.rs

Line 625 in da692f1

if let Err(e) = self

Now I'm thinking of moving blockon_runtime and await_task to Zenoh and then every plugin does not need to define them by itself.
But it's beyond the PR.

[evshary]

LGTM
I can also run the test successfully, but I'll leave @oteffahi to do the final test since I couldn't reproduce the DEL panic.

[oteffahi]

LGTM. Other unrelated issues were found. Will address them in another PR.