New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Options processing refactoring #192

Merged

p-avital merged 2 commits into eclipse-zenoh:master from ZettaScaleLabs:pointer_to_optional_refactoring

Nov 17, 2023

Member

sashacmc commented Nov 17, 2023 •

edited

Loading

Changes options processing from pointer to Option in the functions:

z_declare_pull_subscriber
z_declare_subscriber
z_put
zc_put_owned
z_delete

Benefites:

Consistence with other options processing (e.g. z_declare_publisher, z_declare_queryable, etc.)
Avoid unnecessary unsafe code

Additionally removes unrelevant comments from z_declare_subscriber and z_declare_pull_subscriber

sashacmc added 2 commits

November 17, 2023 12:10


          Subscriber and pull subscriber options processing refactoring

2288c71


          Put/delete options processing refactoring

fe120c8

sashacmc marked this pull request as ready for review

November 17, 2023 12:51

p-avital approved these changes

View reviewed changes

p-avital merged commit 9dd8fc7 into eclipse-zenoh:master

4 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet