Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to pass quoted parameters to rust #196

Merged
merged 4 commits into from
Nov 24, 2023
Merged

allow to pass quoted parameters to rust #196

merged 4 commits into from
Nov 24, 2023

Conversation

milyin
Copy link
Contributor

@milyin milyin commented Nov 20, 2023

This command line allows to perform cross-compilation on arm for x86_64:

cmake -S zenoh-c -B build -DZENOHC_CUSTOM_TARGET=x86_64-unknown-linux-gnu -DZENOHC_CARGO_FLAGS="--config target.x86_64-unknown-linux-gnu.linker=\"/usr/bin/x86_64-linux-gnu-gcc\""

It fails without the VERBATIM option in CMake's add_custom_command. Without this option the quotes around path to linker are incorrectly removed.

After adding VERBATIM compilation started to fail on multiconfig-builders (MSVC, Ninja Multi-Config), so this also was fixed.

@milyin milyin requested a review from Mallets November 21, 2023 16:09
@yellowhatter
Copy link
Contributor

Good solution!

@milyin milyin merged commit 54cbaf5 into master Nov 24, 2023
7 checks passed
@Mallets Mallets deleted the cmake_rust_call_fix branch November 24, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants