feat: add an error code for SessionClosedError #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR missing one of the required labels: {'documentation', 'new feature', 'internal', 'enhancement', 'dependencies', 'bug', 'breaking-change'} |
src/result.rs
Outdated
| @@ -25,6 +25,7 @@ pub const Z_ENETWORK: z_result_t = -4; | |||
| pub const Z_ENULL: z_result_t = -5; | |||
| pub const Z_EUNAVAILABLE: z_result_t = -6; | |||
| pub const Z_EDESERIALIZE: z_result_t = -7; | |||
| pub const Z_SESSION_CLOSED: z_result_t = -8; | |||
There was a problem hiding this comment.
Z_ESESSION_CLOSED maybe, to make in the same style as all other errors ?
src/publisher.rs
Outdated
| result::Z_OK | ||
| match put.wait() { | ||
| Ok(_) => result::Z_OK, | ||
| Err(e) if e.downcast_ref::<SessionClosedError>().is_some() => result::Z_SESSION_CLOSED, |
There was a problem hiding this comment.
do we need some specific tracing message here and in other places ?
There was a problem hiding this comment.
Don't think so, because it's kind of included in the error kind. So the user can choose to ignore it without cluttering the logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #727