Rename ambiguous _iter_driver and pair_contained #136
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
AttachView
containers, the variables_iter_driver
andpair_container
was used to refer to both a reference argument passed to the container, and also to a pointer local variable that was defined inside a lamba function passed to a delating constructor.In general this may not be readable, but on Windows with Visual Studio 2022 (cl.exe version: 19.29.30153) this also creates a compilation error:
This PR solves both the compilation problem (and the general readability problem) by renaming the local variables to a different name.