Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build for windows #217

Closed

Conversation

DenisBiryukov91
Copy link
Contributor

@DenisBiryukov91 DenisBiryukov91 commented Sep 17, 2024

fix build for windows;
add windows build for ci;
Closes #5

Requires eclipse-zenoh/zenoh-pico#679

add windows build for ci (pico support disabled for now);
Copy link

PR missing one of the required labels: {'enhancement', 'documentation', 'dependencies', 'bug', 'breaking-change', 'internal', 'new feature'}

@DenisBiryukov91 DenisBiryukov91 added bug Something isn't working internal Changes not included in the changelog labels Sep 17, 2024
Copy link
Contributor

@yellowhatter yellowhatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@DenisBiryukov91 DenisBiryukov91 marked this pull request as draft September 17, 2024 23:19
@DenisBiryukov91 DenisBiryukov91 marked this pull request as ready for review September 18, 2024 10:56
@DenisBiryukov91
Copy link
Contributor Author

Superseded by #223

@DenisBiryukov91 DenisBiryukov91 deleted the build-windows-ci branch September 23, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working internal Changes not included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable build on Windows support
2 participants